[breaking] Use element2 implementations everywhere, deprecate API with "2". #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorgan
force-pushed
the
analyzer-element2-copy
branch
2 times, most recently
from
3045e21 to
7a53728
Compare
davidmorgan
force-pushed
the
analyzer-element2-copy
branch
from
7a53728 to
a620a32
Compare
scheglov
approved these changes
Apr 3, 2025
stereotype441
added a commit
to stereotype441/drift
that referenced
this pull request
Apr 8, 2025
When a version of the `source_gen` package is published that works with the new analyzer element model, it will not use `2` suffixes on the methods `spanForElement`, `isAssignableFrom`, and `isExactly`. (See dart-lang/source_gen#750). Accordingly, `drift_dev` need to refer to these methods without the `2` suffix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change: if we want to release it as an intermediate state, it will need a major version bump.
We will use it as an intermediate state in google3: with this rolled in, we can migrate users package by package onto the final API. It's not clear if we'll release it externally.